Skip to content

[CHIA-3602] Port wallet coin endpoints to @marshal #19966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Sep 13, 2025
Merged

[CHIA-3602] Port wallet coin endpoints to @marshal #19966

merged 13 commits into from
Sep 13, 2025

Conversation

Quexington
Copy link
Contributor

Another PR following #18593

@Quexington Quexington requested a review from a team as a code owner August 18, 2025 21:47
@Quexington Quexington force-pushed the quex.port_spend_clawback_coins_to_marshal branch from f86eb0a to c8a2fa1 Compare August 19, 2025 16:30
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Aug 19, 2025
@Quexington Quexington force-pushed the quex.port_coin_endpoints_to_marshal branch from 60cabe1 to d5f6323 Compare August 19, 2025 18:20
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Aug 19, 2025
@Quexington Quexington added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Aug 19, 2025
Base automatically changed from quex.port_spend_clawback_coins_to_marshal to main August 20, 2025 19:33
@Quexington Quexington changed the title [CHIA-3602] Port select_coins to @marshal [CHIA-3602] Port wallet coin endpoints to @marshal Aug 22, 2025
@Quexington Quexington requested a review from altendky August 27, 2025 21:22
@Quexington Quexington closed this Sep 8, 2025
@Quexington Quexington reopened this Sep 8, 2025
@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented Sep 8, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 17623276565

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 173 of 180 (96.11%) changed or added relevant lines in 10 files are covered.
  • 345 unchanged lines in 11 files lost coverage.
  • Overall coverage increased (+0.01%) to 91.245%
Changes Missing Coverage Covered Lines Changed/Added Lines %
chia/wallet/wallet_request_types.py 52 53 98.11%
chia/cmds/coin_funcs.py 6 12 50.0%
Files with Coverage Reduction New Missed Lines %
chia/_tests/core/server/test_rate_limits.py 1 99.73%
chia/util/config.py 1 82.25%
chia/full_node/full_node.py 2 87.83%
chia/_tests/wallet/rpc/test_wallet_rpc.py 2 99.02%
chia/wallet/wallet_request_types.py 2 99.32%
chia/full_node/full_node_api.py 3 85.52%
chia/server/node_discovery.py 7 80.86%
chia/wallet/wallet_rpc_client.py 13 94.01%
chia/plotting/check_plots.py 83 0.0%
chia/cmds/wallet_funcs.py 99 85.54%
Totals Coverage Status
Change from base Build 17501273937: 0.01%
Covered Lines: 102814
Relevant Lines: 112537
💛 - Coveralls

altendky
altendky requested changes Sep 10, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

File Coverage Missing Lines
chia/cmds/coin_funcs.py 50.0% lines 225-226, 230, 232-233, 237
chia/wallet/wallet_request_types.py 97.7% lines 493
Total Missing Coverage
141 lines 7 lines 95%

@pmaslana pmaslana merged commit 61034b5 into main Sep 13, 2025
349 of 350 checks passed
@pmaslana pmaslana deleted the quex.port_coin_endpoints_to_marshal branch September 13, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@altendky altendky altendky approved these changes

@markelrod markelrod markelrod approved these changes

Assignees
No one assigned
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Quexington @altendky @markelrod @pmaslana